Skip to content

Commit 7d7dbaf

Browse files
EthanNelson-Moorekuba-moo
authored andcommitted
net: usb: dm9601: remove broken SR9700 support
The SR9700 chip sends more than one packet in a USB transaction, like the DM962x chips can optionally do, but the dm9601 driver does not support this mode, and the hardware does not have the DM962x MODE_CTL register to disable it, so this driver drops packets on SR9700 devices. The sr9700 driver correctly handles receiving more than one packet per transaction. While the dm9601 driver could be improved to handle this, the easiest way to fix this issue in the short term is to remove the SR9700 device ID from the dm9601 driver so the sr9700 driver is always used. This device ID should not have been in more than one driver to begin with. The "Fixes" commit was chosen so that the patch is automatically included in all kernels that have the sr9700 driver, even though the issue affects dm9601. Fixes: c9b3745 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support") Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com> Acked-by: Peter Korsgaard <peter@korsgaard.com> Link: https://patch.msgid.link/20260113063924.74464-1-enelsonmoore@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9ad6930 commit 7d7dbaf

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/net/usb/dm9601.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -603,10 +603,6 @@ static const struct usb_device_id products[] = {
603603
USB_DEVICE(0x0fe6, 0x8101), /* DM9601 USB to Fast Ethernet Adapter */
604604
.driver_info = (unsigned long)&dm9601_info,
605605
},
606-
{
607-
USB_DEVICE(0x0fe6, 0x9700), /* DM9601 USB to Fast Ethernet Adapter */
608-
.driver_info = (unsigned long)&dm9601_info,
609-
},
610606
{
611607
USB_DEVICE(0x0a46, 0x9000), /* DM9000E */
612608
.driver_info = (unsigned long)&dm9601_info,

0 commit comments

Comments
 (0)