Skip to content

Commit 7da1302

Browse files
Uwe Kleine-Königwsakernel
authored andcommitted
i2c: imx: Simplify using devm_clk_get_enabled()
devm_clk_get_enabled() returns the clk already (prepared and) enabled and the automatically called cleanup cares for disabling (and unpreparing). So simplify .probe() and .remove() accordingly. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
1 parent 7a28743 commit 7da1302

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

drivers/i2c/busses/i2c-imx.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1482,17 +1482,11 @@ static int i2c_imx_probe(struct platform_device *pdev)
14821482
ACPI_COMPANION_SET(&i2c_imx->adapter.dev, ACPI_COMPANION(&pdev->dev));
14831483

14841484
/* Get I2C clock */
1485-
i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
1485+
i2c_imx->clk = devm_clk_get_enabled(&pdev->dev, NULL);
14861486
if (IS_ERR(i2c_imx->clk))
14871487
return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
14881488
"can't get I2C clock\n");
14891489

1490-
ret = clk_prepare_enable(i2c_imx->clk);
1491-
if (ret) {
1492-
dev_err(&pdev->dev, "can't enable I2C clock, ret=%d\n", ret);
1493-
return ret;
1494-
}
1495-
14961490
/* Init queue */
14971491
init_waitqueue_head(&i2c_imx->queue);
14981492

@@ -1564,7 +1558,6 @@ static int i2c_imx_probe(struct platform_device *pdev)
15641558
pm_runtime_disable(&pdev->dev);
15651559
pm_runtime_set_suspended(&pdev->dev);
15661560
pm_runtime_dont_use_autosuspend(&pdev->dev);
1567-
clk_disable_unprepare(i2c_imx->clk);
15681561
return ret;
15691562
}
15701563

@@ -1590,16 +1583,13 @@ static int i2c_imx_remove(struct platform_device *pdev)
15901583
imx_i2c_write_reg(0, i2c_imx, IMX_I2C_IFDR);
15911584
imx_i2c_write_reg(0, i2c_imx, IMX_I2C_I2CR);
15921585
imx_i2c_write_reg(0, i2c_imx, IMX_I2C_I2SR);
1593-
clk_disable(i2c_imx->clk);
15941586
}
15951587

15961588
clk_notifier_unregister(i2c_imx->clk, &i2c_imx->clk_change_nb);
15971589
irq = platform_get_irq(pdev, 0);
15981590
if (irq >= 0)
15991591
free_irq(irq, i2c_imx);
16001592

1601-
clk_unprepare(i2c_imx->clk);
1602-
16031593
pm_runtime_put_noidle(&pdev->dev);
16041594
pm_runtime_disable(&pdev->dev);
16051595

0 commit comments

Comments
 (0)