Skip to content

Commit 7e1defa

Browse files
committed
drm/i915: drop -Wall and related disables from cflags as redundant
The kernel top level Makefile, and recently scripts/Makefile.extrawarn, have included -Wall, and the disables -Wno-format-security and $(call cc-disable-warning,frame-address,) for a very long time. They're redundant in our local subdir-ccflags-y and can be dropped. Cc: Arnd Bergmann <arnd@arndb.de> Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Nathan Chancellor <nathan@kernel.org> Acked-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/5ab754ddc2e342c75deb8476275984918e573beb.1697009258.git.jani.nikula@intel.com
1 parent 4a07f06 commit 7e1defa

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

drivers/gpu/drm/i915/Makefile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,20 @@
55

66
# Add a set of useful warning flags and enable -Werror for CI to prevent
77
# trivial mistakes from creeping in. We have to do this piecemeal as we reject
8-
# any patch that isn't warning clean, so turning on -Wall -Wextra (or W=1) we
8+
# any patch that isn't warning clean, so turning on -Wextra (or W=1) we
99
# need to filter out dubious warnings. Still it is our interest
1010
# to keep running locally with W=1 C=1 until we are completely clean.
1111
#
12-
# Note the danger in using -Wall -Wextra is that when CI updates gcc we
12+
# Note the danger in using -Wextra is that when CI updates gcc we
1313
# will most likely get a sudden build breakage... Hopefully we will fix
1414
# new warnings before CI updates!
15-
subdir-ccflags-y := -Wall -Wextra
16-
subdir-ccflags-y += -Wno-format-security
15+
subdir-ccflags-y := -Wextra
1716
subdir-ccflags-y += -Wno-unused-parameter
1817
subdir-ccflags-y += -Wno-type-limits
1918
subdir-ccflags-y += -Wno-missing-field-initializers
2019
subdir-ccflags-y += -Wno-sign-compare
2120
subdir-ccflags-y += -Wno-shift-negative-value
2221
subdir-ccflags-y += $(call cc-option, -Wunused-but-set-variable)
23-
subdir-ccflags-y += $(call cc-disable-warning, frame-address)
2422
subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
2523

2624
# Fine grained warnings disable

0 commit comments

Comments
 (0)