pinctrl: moorefield: Use BUFCFG_PINMODE_GPIO in ->pin_dbg_show()

andy-shev · andy-shev · commit 7e521093113b · 2023-06-06T16:08:20.000+03:00
Use explicit comparison to BUFCFG_PINMODE_GPIO instead of implying it.

Acked-by: Mika Westerberg &lt;mika.westerberg@linux.intel.com&gt;
Signed-off-by: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
diff --git a/drivers/pinctrl/intel/pinctrl-moorefield.c b/drivers/pinctrl/intel/pinctrl-moorefield.c
@@ -504,7 +504,7 @@ static void mofld_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
 	}
 
 	mode = (value & BUFCFG_PINMODE_MASK) >> BUFCFG_PINMODE_SHIFT;
-	if (!mode)
+	if (mode == BUFCFG_PINMODE_GPIO)
 		seq_puts(s, "GPIO ");
 	else
 		seq_printf(s, "mode %d ", mode);

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ static void mofld_pin_dbg_show(struct pinctrl_dev pctldev, struct seq_file s,`
`504`	`504`	`}`
`505`	`505`
`506`	`506`	`mode = (value & BUFCFG_PINMODE_MASK) >> BUFCFG_PINMODE_SHIFT;`
`507`		`- if (!mode)`
	`507`	`+ if (mode == BUFCFG_PINMODE_GPIO)`
`508`	`508`	`seq_puts(s, "GPIO ");`
`509`	`509`	`else`
`510`	`510`	`seq_printf(s, "mode %d ", mode);`