io_uring/notif: refactor io_tx_ubuf_complete()

isilence · axboe · commit 7e58d0af5a58 · 2024-04-15T08:10:49.000-06:00
Flip the dec_and_test "if", that makes the function extension easier in the future. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Link: https://lore.kernel.org/r/43939e2b04dff03bff5d7227c98afedf951227b3.1713185320.git.asml.silence@gmail.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
diff --git a/io_uring/notif.c b/io_uring/notif.c
@@ -37,10 +37,11 @@ static void io_tx_ubuf_callback(struct sk_buff *skb, struct ubuf_info *uarg,
 			WRITE_ONCE(nd->zc_copied, true);
 	}
 
-	if (refcount_dec_and_test(&uarg->refcnt)) {
-		notif->io_task_work.func = io_notif_tw_complete;
-		__io_req_task_work_add(notif, IOU_F_TWQ_LAZY_WAKE);
-	}
+	if (!refcount_dec_and_test(&uarg->refcnt))
+		return;
+
+	notif->io_task_work.func = io_notif_tw_complete;
+	__io_req_task_work_add(notif, IOU_F_TWQ_LAZY_WAKE);
 }
 
 struct io_kiocb *io_alloc_notif(struct io_ring_ctx *ctx)

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,11 @@ static void io_tx_ubuf_callback(struct sk_buff skb, struct ubuf_info uarg,`
`37`	`37`	`WRITE_ONCE(nd->zc_copied, true);`
`38`	`38`	`}`
`39`	`39`
`40`		`- if (refcount_dec_and_test(&uarg->refcnt)) {`
`41`		`- notif->io_task_work.func = io_notif_tw_complete;`
`42`		`- __io_req_task_work_add(notif, IOU_F_TWQ_LAZY_WAKE);`
`43`		`- }`
	`40`	`+ if (!refcount_dec_and_test(&uarg->refcnt))`
	`41`	`+ return;`
	`42`	`+`
	`43`	`+ notif->io_task_work.func = io_notif_tw_complete;`
	`44`	`+ __io_req_task_work_add(notif, IOU_F_TWQ_LAZY_WAKE);`
`44`	`45`	`}`
`45`	`46`
`46`	`47`	`struct io_kiocb io_alloc_notif(struct io_ring_ctx ctx)`