Skip to content

Commit 7e77578

Browse files
tehcastertorvalds
authored andcommitted
mm/mremap: fix vm_pgoff in vma_merge() case 3
After upgrading build guests to v6.3, rpm started segfaulting for specific packages, which was bisected to commit 0503ea8 ("mm/mmap: remove __vma_adjust()"). rpm is doing many mremap() operations with file mappings of its db. The problem is that in vma_merge() case 3 (we merge with the next vma, expanding it downwards) vm_pgoff is not adjusted as it should when vm_start changes. As a result the rpm process most likely sees data from the wrong offset of the file. Fix the vm_pgoff calculation. For case 8 this is a non-functional change as the resulting vm_pgoff is the same. Reported-and-bisected-by: Jiri Slaby <jirislaby@kernel.org> Reported-and-tested-by: Fabian Vogt <fvogt@suse.com> Link: https://bugzilla.suse.com/show_bug.cgi?id=1210903 Fixes: 0503ea8 ("mm/mmap: remove __vma_adjust()") Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Cc: <stable@vger.kernel.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 6e98b09 commit 7e77578

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

mm/mmap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -978,7 +978,7 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
978978
vma = next; /* case 3 */
979979
vma_start = addr;
980980
vma_end = next->vm_end;
981-
vma_pgoff = mid->vm_pgoff;
981+
vma_pgoff = next->vm_pgoff - pglen;
982982
err = 0;
983983
if (mid != next) { /* case 8 */
984984
remove = mid;

0 commit comments

Comments
 (0)