Skip to content

Commit 7e898a9

Browse files
DispatchCodeweiny2
authored andcommitted
nvdimm: replace use of system_wq with system_percpu_wq
Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") Replace system_wq with system_percpu_wq, keeping the same old behavior. The old wq (system_wq) will be kept for a few release cycles. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com>> --- Link: https://patch.msgid.link/20251105150826.248673-1-marco.crivellari@suse.com Signed-off-by: Ira Weiny <ira.weiny@intel.com>
1 parent f59b701 commit 7e898a9

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/nvdimm/security.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ static int security_overwrite(struct nvdimm *nvdimm, unsigned int keyid)
424424
* query.
425425
*/
426426
get_device(dev);
427-
queue_delayed_work(system_wq, &nvdimm->dwork, 0);
427+
queue_delayed_work(system_percpu_wq, &nvdimm->dwork, 0);
428428
}
429429

430430
return rc;
@@ -457,7 +457,7 @@ static void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm)
457457

458458
/* setup delayed work again */
459459
tmo += 10;
460-
queue_delayed_work(system_wq, &nvdimm->dwork, tmo * HZ);
460+
queue_delayed_work(system_percpu_wq, &nvdimm->dwork, tmo * HZ);
461461
nvdimm->sec.overwrite_tmo = min(15U * 60U, tmo);
462462
return;
463463
}

0 commit comments

Comments
 (0)