mmc: cavium-thunderx: Add of_node_put() when breaking out of loop

windhl · Ulf Hansson · commit 7ee480795e41 · 2022-07-21T18:03:08.000+02:00
In thunder_mmc_probe(), we should call of_node_put() when breaking out of for_each_child_of_node() which has increased and decreased the refcount during each iteration. Fixes: 166bac3 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs") Signed-off-by: Liang He <windhl@126.com> Acked-by: Robert Richter <rric@kernel.org> Link: https://lore.kernel.org/r/20220719095216.1241601-2-windhl@126.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
diff --git a/drivers/mmc/host/cavium-thunderx.c b/drivers/mmc/host/cavium-thunderx.c
@@ -142,8 +142,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,
 				continue;
 
 			ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host);
-			if (ret)
+			if (ret) {
+				of_node_put(child_node);
 				goto error;
+			}
 		}
 		i++;
 	}

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,`
`142`	`142`	`continue;`
`143`	`143`
`144`	`144`	`ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host);`
`145`		`- if (ret)`
	`145`	`+ if (ret) {`
	`146`	`+ of_node_put(child_node);`
`146`	`147`	`goto error;`
	`148`	`+ }`
`147`	`149`	`}`
`148`	`150`	`i++;`
`149`	`151`	`}`