Skip to content

Commit 7f1ee4e

Browse files
Hugh Dickinsakpm00
authored andcommitted
mempolicy trivia: delete those ancient pr_debug()s
Delete those ancient pr_debug()s - PDprintk()s in Andi Kleen's original submission of core NUMA API, and useful when debugging shared mempolicy lifetime back then, but not used recently. Link: https://lkml.kernel.org/r/f25135-ffb2-40d8-9577-720772b333@google.com Signed-off-by: Hugh Dickins <hughd@google.com> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Andi Kleen <ak@linux.intel.com> Cc: Christoph Lameter <cl@linux.com> Cc: David Hildenbrand <david@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Huang, Ying" <ying.huang@intel.com> Cc: Kefeng Wang <wangkefeng.wang@huawei.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Michal Hocko <mhocko@suse.com> Cc: Mike Kravetz <mike.kravetz@oracle.com> Cc: Nhat Pham <nphamcs@gmail.com> Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Tejun heo <tj@kernel.org> Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com> Cc: Yang Shi <shy828301@gmail.com> Cc: Yosry Ahmed <yosryahmed@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 1cb5d11 commit 7f1ee4e

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

mm/mempolicy.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -264,9 +264,6 @@ static struct mempolicy *mpol_new(unsigned short mode, unsigned short flags,
264264
{
265265
struct mempolicy *policy;
266266

267-
pr_debug("setting mode %d flags %d nodes[0] %lx\n",
268-
mode, flags, nodes ? nodes_addr(*nodes)[0] : NUMA_NO_NODE);
269-
270267
if (mode == MPOL_DEFAULT) {
271268
if (nodes && !nodes_empty(*nodes))
272269
return ERR_PTR(-EINVAL);
@@ -768,11 +765,6 @@ static int vma_replace_policy(struct vm_area_struct *vma,
768765

769766
vma_assert_write_locked(vma);
770767

771-
pr_debug("vma %lx-%lx/%lx vm_ops %p vm_file %p set_policy %p\n",
772-
vma->vm_start, vma->vm_end, vma->vm_pgoff,
773-
vma->vm_ops, vma->vm_file,
774-
vma->vm_ops ? vma->vm_ops->set_policy : NULL);
775-
776768
new = mpol_dup(pol);
777769
if (IS_ERR(new))
778770
return PTR_ERR(new);
@@ -1273,10 +1265,6 @@ static long do_mbind(unsigned long start, unsigned long len,
12731265
if (!new)
12741266
flags |= MPOL_MF_DISCONTIG_OK;
12751267

1276-
pr_debug("mbind %lx-%lx mode:%d flags:%d nodes:%lx\n",
1277-
start, start + len, mode, mode_flags,
1278-
nmask ? nodes_addr(*nmask)[0] : NUMA_NO_NODE);
1279-
12801268
if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL))
12811269
lru_cache_disable();
12821270
{
@@ -2496,8 +2484,6 @@ static void sp_insert(struct shared_policy *sp, struct sp_node *new)
24962484
}
24972485
rb_link_node(&new->nd, parent, p);
24982486
rb_insert_color(&new->nd, &sp->root);
2499-
pr_debug("inserting %lx-%lx: %d\n", new->start, new->end,
2500-
new->policy ? new->policy->mode : 0);
25012487
}
25022488

25032489
/* Find shared policy intersecting idx */
@@ -2636,7 +2622,6 @@ void mpol_put_task_policy(struct task_struct *task)
26362622

26372623
static void sp_delete(struct shared_policy *sp, struct sp_node *n)
26382624
{
2639-
pr_debug("deleting %lx-l%lx\n", n->start, n->end);
26402625
rb_erase(&n->nd, &sp->root);
26412626
sp_free(n);
26422627
}
@@ -2793,12 +2778,6 @@ int mpol_set_shared_policy(struct shared_policy *info,
27932778
struct sp_node *new = NULL;
27942779
unsigned long sz = vma_pages(vma);
27952780

2796-
pr_debug("set_shared_policy %lx sz %lu %d %d %lx\n",
2797-
vma->vm_pgoff,
2798-
sz, npol ? npol->mode : -1,
2799-
npol ? npol->flags : -1,
2800-
npol ? nodes_addr(npol->nodes)[0] : NUMA_NO_NODE);
2801-
28022781
if (npol) {
28032782
new = sp_alloc(vma->vm_pgoff, vma->vm_pgoff + sz, npol);
28042783
if (!new)

0 commit comments

Comments
 (0)