@@ -15,6 +15,7 @@ use kernel::{
1515 security,
1616 seq_file:: SeqFile ,
1717 seq_print,
18+ sync:: atomic:: { ordering:: Relaxed , Atomic } ,
1819 sync:: poll:: { PollCondVar , PollTable } ,
1920 sync:: { Arc , SpinLock } ,
2021 task:: Task ,
@@ -34,10 +35,7 @@ use crate::{
3435 BinderReturnWriter , DArc , DLArc , DTRWrap , DeliverCode , DeliverToRead ,
3536} ;
3637
37- use core:: {
38- mem:: size_of,
39- sync:: atomic:: { AtomicU32 , Ordering } ,
40- } ;
38+ use core:: mem:: size_of;
4139
4240/// Stores the layout of the scatter-gather entries. This is used during the `translate_objects`
4341/// call and is discarded when it returns.
@@ -273,8 +271,8 @@ const LOOPER_POLL: u32 = 0x40;
273271impl InnerThread {
274272 fn new ( ) -> Result < Self > {
275273 fn next_err_id ( ) -> u32 {
276- static EE_ID : AtomicU32 = AtomicU32 :: new ( 0 ) ;
277- EE_ID . fetch_add ( 1 , Ordering :: Relaxed )
274+ static EE_ID : Atomic < u32 > = Atomic :: new ( 0 ) ;
275+ EE_ID . fetch_add ( 1 , Relaxed )
278276 }
279277
280278 Ok ( Self {
@@ -1537,26 +1535,26 @@ impl Thread {
15371535
15381536#[ pin_data]
15391537struct ThreadError {
1540- error_code : AtomicU32 ,
1538+ error_code : Atomic < u32 > ,
15411539 #[ pin]
15421540 links_track : AtomicTracker ,
15431541}
15441542
15451543impl ThreadError {
15461544 fn try_new ( ) -> Result < DArc < Self > > {
15471545 DTRWrap :: arc_pin_init ( pin_init ! ( Self {
1548- error_code: AtomicU32 :: new( BR_OK ) ,
1546+ error_code: Atomic :: new( BR_OK ) ,
15491547 links_track <- AtomicTracker :: new( ) ,
15501548 } ) )
15511549 . map ( ListArc :: into_arc)
15521550 }
15531551
15541552 fn set_error_code ( & self , code : u32 ) {
1555- self . error_code . store ( code, Ordering :: Relaxed ) ;
1553+ self . error_code . store ( code, Relaxed ) ;
15561554 }
15571555
15581556 fn is_unused ( & self ) -> bool {
1559- self . error_code . load ( Ordering :: Relaxed ) == BR_OK
1557+ self . error_code . load ( Relaxed ) == BR_OK
15601558 }
15611559}
15621560
@@ -1566,8 +1564,8 @@ impl DeliverToRead for ThreadError {
15661564 _thread : & Thread ,
15671565 writer : & mut BinderReturnWriter < ' _ > ,
15681566 ) -> Result < bool > {
1569- let code = self . error_code . load ( Ordering :: Relaxed ) ;
1570- self . error_code . store ( BR_OK , Ordering :: Relaxed ) ;
1567+ let code = self . error_code . load ( Relaxed ) ;
1568+ self . error_code . store ( BR_OK , Relaxed ) ;
15711569 writer. write_code ( code) ?;
15721570 Ok ( true )
15731571 }
@@ -1583,7 +1581,7 @@ impl DeliverToRead for ThreadError {
15831581 m,
15841582 "{}transaction error: {}\n " ,
15851583 prefix,
1586- self . error_code. load( Ordering :: Relaxed )
1584+ self . error_code. load( Relaxed )
15871585 ) ;
15881586 Ok ( ( ) )
15891587 }
0 commit comments