Skip to content

Commit 7fb2b24

Browse files
mrutland-armKAGA-KOKO
authored andcommitted
alpha: Snapshot thread flags
Some thread flags can be set remotely, and so even when IRQs are disabled, the flags can change under our feet. Generally this is unlikely to cause a problem in practice, but it is somewhat unsound, and KCSAN will legitimately warn that there is a data race. To avoid such issues, a snapshot of the flags has to be taken prior to using them. Some places already use READ_ONCE() for that, others do not. Convert them all to the new flag accessor helpers. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Paul E. McKenney <paulmck@kernel.org> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Matt Turner <mattst88@gmail.com> Cc: Richard Henderson <rth@twiddle.net> Link: https://lore.kernel.org/r/20211129130653.2037928-5-mark.rutland@arm.com
1 parent 0569b24 commit 7fb2b24

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/alpha/kernel/signal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,6 +535,6 @@ do_work_pending(struct pt_regs *regs, unsigned long thread_flags,
535535
}
536536
}
537537
local_irq_disable();
538-
thread_flags = current_thread_info()->flags;
538+
thread_flags = read_thread_flags();
539539
} while (thread_flags & _TIF_WORK_MASK);
540540
}

0 commit comments

Comments
 (0)