Skip to content

Commit 7ff61cd

Browse files
gregkhalexdeucher
authored andcommitted
drm/amdgpu: use default_groups in kobj_type
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the amdgpu sysfs code to use default_groups field which has been the preferred way since aa30f47 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field. Cc: Alex Deucher <alexander.deucher@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Hawking Zhang <Hawking.Zhang@amd.com> Cc: John Clements <john.clements@amd.com> Cc: Felix Kuehling <Felix.Kuehling@amd.com> Cc: Jonathan Kim <jonathan.kim@amd.com> Cc: Kevin Wang <kevin1.wang@amd.com> Cc: shaoyunl <shaoyun.liu@amd.com> Cc: Tao Zhou <tao.zhou1@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 4cc9f86 commit 7ff61cd

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ static struct attribute *amdgpu_xgmi_hive_attrs[] = {
208208
&amdgpu_xgmi_hive_id,
209209
NULL
210210
};
211+
ATTRIBUTE_GROUPS(amdgpu_xgmi_hive);
211212

212213
static ssize_t amdgpu_xgmi_show_attrs(struct kobject *kobj,
213214
struct attribute *attr, char *buf)
@@ -237,7 +238,7 @@ static const struct sysfs_ops amdgpu_xgmi_hive_ops = {
237238
struct kobj_type amdgpu_xgmi_hive_type = {
238239
.release = amdgpu_xgmi_hive_release,
239240
.sysfs_ops = &amdgpu_xgmi_hive_ops,
240-
.default_attrs = amdgpu_xgmi_hive_attrs,
241+
.default_groups = amdgpu_xgmi_hive_groups,
241242
};
242243

243244
static ssize_t amdgpu_xgmi_show_device_id(struct device *dev,

0 commit comments

Comments
 (0)