bcachefs: don't free error pointers

Kent Overstreet · Kent Overstreet · commit 7ffec9ccdc6a · 2024-05-06T10:58:17.000-04:00
Reported-by: syzbot+3333603f569fc2ef258c@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c
@@ -902,7 +902,8 @@ int bch2_fs_recovery(struct bch_fs *c)
 		bch2_journal_keys_put_initial(c);
 		bch2_find_btree_nodes_exit(&c->found_btree_nodes);
 	}
-	kfree(clean);
+	if (!IS_ERR(clean))
+		kfree(clean);
 
 	if (!ret &&
 	    test_bit(BCH_FS_need_delete_dead_snapshots, &c->flags) &&

Original file line number	Diff line number	Diff line change
`@@ -902,7 +902,8 @@ int bch2_fs_recovery(struct bch_fs *c)`
`902`	`902`	`bch2_journal_keys_put_initial(c);`
`903`	`903`	`bch2_find_btree_nodes_exit(&c->found_btree_nodes);`
`904`	`904`	`}`
`905`		`- kfree(clean);`
	`905`	`+ if (!IS_ERR(clean))`
	`906`	`+ kfree(clean);`
`906`	`907`
`907`	`908`	`if (!ret &&`
`908`	`909`	`test_bit(BCH_FS_need_delete_dead_snapshots, &c->flags) &&`