Skip to content

Commit 80cc1d1

Browse files
yangyang20220519ingomolnar
authored andcommitted
sched/psi: Avoid updating PSI triggers and ->rtpoll_total when there are no state changes
When psimon wakes up and there are no state changes for ->rtpoll_states, it's unnecessary to update triggers and ->rtpoll_total because the pressures being monitored by the user have not changed. This will help to slightly reduce unnecessary computations of PSI. [ mingo: Changelog updates ] Signed-off-by: Yang Yang <yang.yang29@zte.com.cn> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Peter Ziljstra <peterz@infradead.org> Link: https://lore.kernel.org/r/202310101641075436843@zte.com.cn
1 parent b19fdb1 commit 80cc1d1

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

kernel/sched/psi.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -704,11 +704,12 @@ static void psi_rtpoll_work(struct psi_group *group)
704704
}
705705

706706
if (now >= group->rtpoll_next_update) {
707-
update_triggers(group, now, &update_total, PSI_POLL);
708-
group->rtpoll_next_update = now + group->rtpoll_min_period;
709-
if (update_total)
707+
if (changed_states & group->rtpoll_states) {
708+
update_triggers(group, now, &update_total, PSI_POLL);
710709
memcpy(group->rtpoll_total, group->total[PSI_POLL],
711710
sizeof(group->rtpoll_total));
711+
}
712+
group->rtpoll_next_update = now + group->rtpoll_min_period;
712713
}
713714

714715
psi_schedule_rtpoll_work(group,

0 commit comments

Comments
 (0)