Skip to content

Commit 80db457

Browse files
committed
Merge tag 'auxdisplay-v6.13-1' of git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-auxdisplay
Pull auxdisplay update from Andy Shevchenko: - Move Holtek 16k33 driver to use agnostic i2c_get_match_data() - Miscellaneuous cleanups * tag 'auxdisplay-v6.13-1' of git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-auxdisplay: auxdisplay: Remove unused functions auxdisplay: ht16k33: Make use of i2c_get_match_data() auxdisplay: Drop explicit initialization of struct i2c_device_id::driver_data to 0
2 parents 3855629 + 0b028ff commit 80db457

4 files changed

Lines changed: 6 additions & 35 deletions

File tree

drivers/auxdisplay/cfag12864b.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ module_param(cfag12864b_rate, uint, 0444);
3737
MODULE_PARM_DESC(cfag12864b_rate,
3838
"Refresh rate (hertz)");
3939

40-
unsigned int cfag12864b_getrate(void)
41-
{
42-
return cfag12864b_rate;
43-
}
44-
4540
/*
4641
* cfag12864b Commands
4742
*
@@ -249,11 +244,6 @@ void cfag12864b_disable(void)
249244
mutex_unlock(&cfag12864b_mutex);
250245
}
251246

252-
unsigned char cfag12864b_isenabled(void)
253-
{
254-
return cfag12864b_updating;
255-
}
256-
257247
static void cfag12864b_update(struct work_struct *work)
258248
{
259249
unsigned char c;
@@ -293,10 +283,8 @@ static void cfag12864b_update(struct work_struct *work)
293283
*/
294284

295285
EXPORT_SYMBOL_GPL(cfag12864b_buffer);
296-
EXPORT_SYMBOL_GPL(cfag12864b_getrate);
297286
EXPORT_SYMBOL_GPL(cfag12864b_enable);
298287
EXPORT_SYMBOL_GPL(cfag12864b_disable);
299-
EXPORT_SYMBOL_GPL(cfag12864b_isenabled);
300288

301289
/*
302290
* Is the module inited?

drivers/auxdisplay/ht16k33.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,6 @@ static int ht16k33_seg_probe(struct device *dev, struct ht16k33_priv *priv,
657657
static int ht16k33_probe(struct i2c_client *client)
658658
{
659659
struct device *dev = &client->dev;
660-
const struct of_device_id *id;
661660
struct ht16k33_priv *priv;
662661
uint32_t dft_brightness;
663662
int err;
@@ -672,9 +671,8 @@ static int ht16k33_probe(struct i2c_client *client)
672671
return -ENOMEM;
673672

674673
priv->client = client;
675-
id = i2c_of_match_device(dev->driver->of_match_table, client);
676-
if (id)
677-
priv->type = (uintptr_t)id->data;
674+
priv->type = (uintptr_t)i2c_get_match_data(client);
675+
678676
i2c_set_clientdata(client, priv);
679677

680678
err = ht16k33_initialize(priv);
@@ -747,7 +745,9 @@ static void ht16k33_remove(struct i2c_client *client)
747745
}
748746

749747
static const struct i2c_device_id ht16k33_i2c_match[] = {
750-
{ "ht16k33", 0 },
748+
{ "3108", DISP_QUAD_7SEG },
749+
{ "3130", DISP_QUAD_14SEG },
750+
{ "ht16k33", DISP_MATRIX },
751751
{ }
752752
};
753753
MODULE_DEVICE_TABLE(i2c, ht16k33_i2c_match);

drivers/auxdisplay/lcd2s.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ static void lcd2s_i2c_remove(struct i2c_client *i2c)
349349
}
350350

351351
static const struct i2c_device_id lcd2s_i2c_id[] = {
352-
{ "lcd2s", 0 },
352+
{ "lcd2s" },
353353
{ }
354354
};
355355
MODULE_DEVICE_TABLE(i2c, lcd2s_i2c_id);

include/linux/cfag12864b.h

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@
2727
*/
2828
extern unsigned char * cfag12864b_buffer;
2929

30-
/*
31-
* Get the refresh rate of the LCD
32-
*
33-
* Returns the refresh rate (hertz).
34-
*/
35-
extern unsigned int cfag12864b_getrate(void);
36-
3730
/*
3831
* Enable refreshing
3932
*
@@ -49,16 +42,6 @@ extern unsigned char cfag12864b_enable(void);
4942
*/
5043
extern void cfag12864b_disable(void);
5144

52-
/*
53-
* Is enabled refreshing? (is anyone using the module?)
54-
*
55-
* Returns 0 if refreshing is not enabled (anyone is using it),
56-
* or != 0 if refreshing is enabled (someone is using it).
57-
*
58-
* Useful for buffer read-only modules.
59-
*/
60-
extern unsigned char cfag12864b_isenabled(void);
61-
6245
/*
6346
* Is the module inited?
6447
*/

0 commit comments

Comments
 (0)