s390/qeth: Fix vipa deletion

Thorsten Winkler · davem330 · commit 80de809bd35e · 2023-07-05T10:47:45.000+01:00
Change boolean parameter of function "qeth_l3_vipa_store" inside the "qeth_l3_dev_vipa_del4_store" function from "true" to "false" because "true" is used for adding a virtual ip address and "false" for deleting. Fixes: 2390166 ("s390/qeth: clean up L3 sysfs code") Reviewed-by: Alexandra Winter <wintera@linux.ibm.com> Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com> Signed-off-by: Thorsten Winkler <twinkler@linux.ibm.com> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
@@ -625,7 +625,7 @@ static QETH_DEVICE_ATTR(vipa_add4, add4, 0644,
 static ssize_t qeth_l3_dev_vipa_del4_store(struct device *dev,
 		struct device_attribute *attr, const char *buf, size_t count)
 {
-	return qeth_l3_vipa_store(dev, buf, true, count, QETH_PROT_IPV4);
+	return qeth_l3_vipa_store(dev, buf, false, count, QETH_PROT_IPV4);
 }
 
 static QETH_DEVICE_ATTR(vipa_del4, del4, 0200, NULL,

Original file line number	Diff line number	Diff line change
`@@ -625,7 +625,7 @@ static QETH_DEVICE_ATTR(vipa_add4, add4, 0644,`
`625`	`625`	`static ssize_t qeth_l3_dev_vipa_del4_store(struct device *dev,`
`626`	`626`	`struct device_attribute attr, const char buf, size_t count)`
`627`	`627`	`{`
`628`		`- return qeth_l3_vipa_store(dev, buf, true, count, QETH_PROT_IPV4);`
	`628`	`+ return qeth_l3_vipa_store(dev, buf, false, count, QETH_PROT_IPV4);`
`629`	`629`	`}`
`630`	`630`
`631`	`631`	`static QETH_DEVICE_ATTR(vipa_del4, del4, 0200, NULL,`