Skip to content

Commit 80f9c60

Browse files
mbrost05Thomas Hellström
authored andcommitted
drm/xe: Use usleep_range for accurate long-running workload timeslicing
msleep is not very accurate in terms of how long it actually sleeps, whereas usleep_range is precise. Replace the timeslice sleep for long-running workloads with the more accurate usleep_range to avoid jitter if the sleep period is less than 20ms. Fixes: dd08ebf ("drm/xe: Introduce a new DRM driver for Intel GPUs") Cc: stable@vger.kernel.org Signed-off-by: Matthew Brost <matthew.brost@intel.com> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Link: https://patch.msgid.link/20251212182847.1683222-3-matthew.brost@intel.com (cherry picked from commit ca415c4) Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
1 parent fe3ccd2 commit 80f9c60

1 file changed

Lines changed: 19 additions & 1 deletion

File tree

drivers/gpu/drm/xe/xe_guc_submit.c

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -717,6 +717,24 @@ static bool vf_recovery(struct xe_guc *guc)
717717
return xe_gt_recovery_pending(guc_to_gt(guc));
718718
}
719719

720+
static inline void relaxed_ms_sleep(unsigned int delay_ms)
721+
{
722+
unsigned long min_us, max_us;
723+
724+
if (!delay_ms)
725+
return;
726+
727+
if (delay_ms > 20) {
728+
msleep(delay_ms);
729+
return;
730+
}
731+
732+
min_us = mul_u32_u32(delay_ms, 1000);
733+
max_us = min_us + 500;
734+
735+
usleep_range(min_us, max_us);
736+
}
737+
720738
static int wq_wait_for_space(struct xe_exec_queue *q, u32 wqi_size)
721739
{
722740
struct xe_guc *guc = exec_queue_to_guc(q);
@@ -1587,7 +1605,7 @@ static void __guc_exec_queue_process_msg_suspend(struct xe_sched_msg *msg)
15871605
since_resume_ms;
15881606

15891607
if (wait_ms > 0 && q->guc->resume_time)
1590-
msleep(wait_ms);
1608+
relaxed_ms_sleep(wait_ms);
15911609

15921610
set_exec_queue_suspended(q);
15931611
disable_scheduling(q, false);

0 commit comments

Comments
 (0)