Skip to content

Commit 81e8788

Browse files
psi-suegregkh
authored andcommitted
staging: fbtft: core: set smem_len before fb_deferred_io_init call
The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before initializing info->fix.smem_len. It is set to zero by the framebuffer_alloc() function. It will trigger a WARN_ON() at the start of fb_deferred_io_init() and the function will not do anything. Fixes: 856082f ("fbdev: defio: fix the pagelist corruption") Signed-off-by: Peter Suti <peter.suti@streamunlimited.com> Link: https://lore.kernel.org/r/20220727073550.1491126-1-peter.suti@streamunlimited.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2b5002e commit 81e8788

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/staging/fbtft/fbtft-core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,6 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
654654
fbdefio->delay = HZ / fps;
655655
fbdefio->sort_pagereflist = true;
656656
fbdefio->deferred_io = fbtft_deferred_io;
657-
fb_deferred_io_init(info);
658657

659658
snprintf(info->fix.id, sizeof(info->fix.id), "%s", dev->driver->name);
660659
info->fix.type = FB_TYPE_PACKED_PIXELS;
@@ -665,6 +664,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
665664
info->fix.line_length = width * bpp / 8;
666665
info->fix.accel = FB_ACCEL_NONE;
667666
info->fix.smem_len = vmem_size;
667+
fb_deferred_io_init(info);
668668

669669
info->var.rotate = pdata->rotate;
670670
info->var.xres = width;

0 commit comments

Comments
 (0)