Skip to content

Commit 829a795

Browse files
rddunlapjoergroedel
authored andcommitted
iommu/fsl: fix all kernel-doc warnings in fsl_pamu.c
Fix kernel-doc warnings as reported by the kernel test robot: fsl_pamu.c:192: warning: expecting prototype for pamu_config_paace(). Prototype was for pamu_config_ppaace() instead fsl_pamu.c:239: warning: Function parameter or member 'omi_index' not described in 'get_ome_index' fsl_pamu.c:239: warning: Function parameter or member 'dev' not described in 'get_ome_index' fsl_pamu.c:332: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Setup operation mapping and stash destinations for QMAN and QMAN portal. fsl_pamu.c:361: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Setup the operation mapping table for various devices. This is a static Fixes: 695093e ("iommu/fsl: Freescale PAMU driver and iommu implementation.") Fixes: cd70d46 ("iommu/fsl: Various cleanups") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Link: lore.kernel.org/r/202302281151.B1WtZvSC-lkp@intel.com Cc: Aditya Srivastava <yashsri421@gmail.com> Cc: Joerg Roedel <joro@8bytes.org> Cc: Will Deacon <will@kernel.org> Cc: Robin Murphy <robin.murphy@arm.com> Cc: iommu@lists.linux.dev Cc: Timur Tabi <timur@tabi.org> Cc: Varun Sethi <Varun.Sethi@freescale.com> Cc: Emil Medve <Emilian.Medve@Freescale.com> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> Acked-by: Timur Tabi <timur@kernel.org> Link: https://lore.kernel.org/r/20230308034504.9985-1-rdunlap@infradead.org Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent e8d018d commit 829a795

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

drivers/iommu/fsl_pamu.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ int pamu_update_paace_stash(int liodn, u32 value)
178178
}
179179

180180
/**
181-
* pamu_config_paace() - Sets up PPAACE entry for specified liodn
181+
* pamu_config_ppaace() - Sets up PPAACE entry for specified liodn
182182
*
183183
* @liodn: Logical IO device number
184184
* @omi: Operation mapping index -- if ~omi == 0 then omi not defined
@@ -232,7 +232,8 @@ int pamu_config_ppaace(int liodn, u32 omi, u32 stashid, int prot)
232232
/**
233233
* get_ome_index() - Returns the index in the operation mapping table
234234
* for device.
235-
* @*omi_index: pointer for storing the index value
235+
* @omi_index: pointer for storing the index value
236+
* @dev: target device
236237
*
237238
*/
238239
void get_ome_index(u32 *omi_index, struct device *dev)
@@ -328,7 +329,7 @@ u32 get_stash_id(u32 stash_dest_hint, u32 vcpu)
328329
#define QMAN_PORTAL_PAACE 2
329330
#define BMAN_PAACE 3
330331

331-
/**
332+
/*
332333
* Setup operation mapping and stash destinations for QMAN and QMAN portal.
333334
* Memory accesses to QMAN and BMAN private memory need not be coherent, so
334335
* clear the PAACE entry coherency attribute for them.
@@ -357,7 +358,7 @@ static void setup_qbman_paace(struct paace *ppaace, int paace_type)
357358
}
358359
}
359360

360-
/**
361+
/*
361362
* Setup the operation mapping table for various devices. This is a static
362363
* table where each table index corresponds to a particular device. PAMU uses
363364
* this table to translate device transaction to appropriate corenet

0 commit comments

Comments
 (0)