drm/amdgpu: fix error handling in ib_schedule()

alexdeucher · alexdeucher · commit 82a401ceffba · 2026-01-20T21:53:18.000-05:00
If fence emit fails, free the fence if necessary. Fixes: db36632 ("drm/amdgpu: clean up and unify hw fence handling") Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 5eb680a)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
@@ -302,7 +302,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned int num_ibs,
 		if (job && job->vmid)
 			amdgpu_vmid_reset(adev, ring->vm_hub, job->vmid);
 		amdgpu_ring_undo(ring);
-		return r;
+		goto free_fence;
 	}
 	*f = &af->base;
 	/* get a ref for the job */

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned int num_ibs,`
`302`	`302`	`if (job && job->vmid)`
`303`	`303`	`amdgpu_vmid_reset(adev, ring->vm_hub, job->vmid);`
`304`	`304`	`amdgpu_ring_undo(ring);`
`305`		`- return r;`
	`305`	`+ goto free_fence;`
`306`	`306`	`}`
`307`	`307`	`*f = &af->base;`
`308`	`308`	`/* get a ref for the job */`