net: bridge: Exit if multicast_init_stats fails

leitao · kuba-moo · commit 82a48affb36f · 2024-02-28T20:15:32.000-08:00
If br_multicast_init_stats() fails, there is no need to set lockdep classes. Just return from the error path. Signed-off-by: Breno Leitao <leitao@debian.org> Acked-by: Nikolay Aleksandrov <razor@blackwall.org> Link: https://lore.kernel.org/r/20240227182338.2739884-2-leitao@debian.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
@@ -135,10 +135,11 @@ static int br_dev_init(struct net_device *dev)
 		br_vlan_flush(br);
 		br_mdb_hash_fini(br);
 		br_fdb_hash_fini(br);
+		return err;
 	}
 
 	netdev_lockdep_set_classes(dev);
-	return err;
+	return 0;
 }
 
 static void br_dev_uninit(struct net_device *dev)

Original file line number	Diff line number	Diff line change
`@@ -135,10 +135,11 @@ static int br_dev_init(struct net_device *dev)`
`135`	`135`	`br_vlan_flush(br);`
`136`	`136`	`br_mdb_hash_fini(br);`
`137`	`137`	`br_fdb_hash_fini(br);`
	`138`	`+ return err;`
`138`	`139`	`}`
`139`	`140`
`140`	`141`	`netdev_lockdep_set_classes(dev);`
`141`		`- return err;`
	`142`	`+ return 0;`
`142`	`143`	`}`
`143`	`144`
`144`	`145`	`static void br_dev_uninit(struct net_device *dev)`