Skip to content

Commit 82b951e

Browse files
Ye BinAlex Williamson
authored andcommitted
vfio/pci: fix potential memory leak in vfio_intx_enable()
If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak. Fixes: 18c198c ("vfio/pci: Create persistent INTx handler") Signed-off-by: Ye Bin <yebin10@huawei.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Acked-by: Reinette Chatre <reinette.chatre@intel.com> Link: https://lore.kernel.org/r/20240415015029.3699844-1-yebin10@huawei.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
1 parent d530531 commit 82b951e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/vfio/pci/vfio_pci_intrs.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
267267
return -ENOMEM;
268268

269269
ctx = vfio_irq_ctx_alloc(vdev, 0);
270-
if (!ctx)
270+
if (!ctx) {
271+
kfree(name);
271272
return -ENOMEM;
273+
}
272274

273275
ctx->name = name;
274276
ctx->trigger = trigger;

0 commit comments

Comments
 (0)