Skip to content

Commit 82c9b7e

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: cros_ec_proto: add Kunit test for empty payload
cros_ec_wait_until_complete() sends EC_CMD_GET_COMMS_STATUS which expects to receive sizeof(struct ec_response_get_comms_status) from cros_ec_xfer_command(). Add Kunit test and expect to receive an error code when cros_ec_xfer_command() returns 0. Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> Link: https://lore.kernel.org/r/20220718050914.2267370-10-tzungbi@kernel.org
1 parent 7f95d2b commit 82c9b7e

1 file changed

Lines changed: 31 additions & 0 deletions

File tree

drivers/platform/chrome/cros_ec_proto_test.c

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1934,6 +1934,36 @@ static void cros_ec_proto_test_cmd_xfer_in_progress_return_error(struct kunit *t
19341934
KUNIT_EXPECT_EQ(test, cros_kunit_ec_pkt_xfer_mock_called, 2);
19351935
}
19361936

1937+
static void cros_ec_proto_test_cmd_xfer_in_progress_return0(struct kunit *test)
1938+
{
1939+
struct cros_ec_proto_test_priv *priv = test->priv;
1940+
struct cros_ec_device *ec_dev = &priv->ec_dev;
1941+
struct ec_xfer_mock *mock;
1942+
int ret;
1943+
struct cros_ec_command msg;
1944+
1945+
memset(&msg, 0, sizeof(msg));
1946+
1947+
ec_dev->pkt_xfer = cros_kunit_ec_pkt_xfer_mock;
1948+
1949+
/* For the first host command to return EC_RES_IN_PROGRESS. */
1950+
{
1951+
mock = cros_kunit_ec_xfer_mock_addx(test, 0, EC_RES_IN_PROGRESS, 0);
1952+
KUNIT_ASSERT_PTR_NE(test, mock, NULL);
1953+
}
1954+
1955+
/* For EC_CMD_GET_COMMS_STATUS. */
1956+
{
1957+
mock = cros_kunit_ec_xfer_mock_add(test, 0);
1958+
KUNIT_ASSERT_PTR_NE(test, mock, NULL);
1959+
}
1960+
1961+
ret = cros_ec_cmd_xfer(ec_dev, &msg);
1962+
KUNIT_EXPECT_EQ(test, ret, -EPROTO);
1963+
1964+
KUNIT_EXPECT_EQ(test, cros_kunit_ec_pkt_xfer_mock_called, 2);
1965+
}
1966+
19371967
static void cros_ec_proto_test_release(struct device *dev)
19381968
{
19391969
}
@@ -2013,6 +2043,7 @@ static struct kunit_case cros_ec_proto_test_cases[] = {
20132043
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_retries_status_processing),
20142044
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_xfer_error),
20152045
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_return_error),
2046+
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_return0),
20162047
{}
20172048
};
20182049

0 commit comments

Comments
 (0)