Skip to content

Commit 835bed1

Browse files
zx2c4hdeller
authored andcommitted
fbdev: sisfb: use explicitly signed char
With char becoming unsigned by default, and with `char` alone being ambiguous and based on architecture, signed chars need to be marked explicitly as such. This fixes warnings like: drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned Cc: Thomas Winischhofer <thomas@winischhofer.net> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Helge Deller <deller@gmx.de> Cc: linux-usb@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent cc67482 commit 835bed1

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/usb/misc/sisusbvga/sisusb_struct.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ struct SiS_Ext {
9191
unsigned char VB_ExtTVYFilterIndex;
9292
unsigned char VB_ExtTVYFilterIndexROM661;
9393
unsigned char REFindex;
94-
char ROMMODEIDX661;
94+
signed char ROMMODEIDX661;
9595
};
9696

9797
struct SiS_Ext2 {

drivers/video/fbdev/sis/vstruct.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ struct SiS_Ext {
148148
unsigned char VB_ExtTVYFilterIndex;
149149
unsigned char VB_ExtTVYFilterIndexROM661;
150150
unsigned char REFindex;
151-
char ROMMODEIDX661;
151+
signed char ROMMODEIDX661;
152152
};
153153

154154
struct SiS_Ext2 {

0 commit comments

Comments
 (0)