Skip to content

Commit 83714dc

Browse files
kaleshap86kuba-moo
authored andcommitted
bnxt_en: Fix reporting of test result in ethtool selftest
When the selftest command fails, driver is not reporting the failure by updating the "test->flags" when bnxt_close_nic() fails. Fixes: eb51365 ("bnxt_en: Add basic ethtool -t selftest support.") Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent c5cff16 commit 83714dc

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3738,6 +3738,7 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest,
37383738
bnxt_ulp_stop(bp);
37393739
rc = bnxt_close_nic(bp, true, false);
37403740
if (rc) {
3741+
etest->flags |= ETH_TEST_FL_FAILED;
37413742
bnxt_ulp_start(bp, rc);
37423743
return;
37433744
}

0 commit comments

Comments
 (0)