Skip to content

Commit 8379436

Browse files
damien-lemoalaxboe
authored andcommitted
block: Cleanup set_capacity()/bdev_set_nr_sectors()
The code for setting a block device capacity (bd_nr_sectors field of struct block_device) is duplicated in set_capacity() and bdev_set_nr_sectors(). Clean this up by making bdev_set_nr_sectors() a block layer internal function defined in block/bdev.c instead of having this function statically defined in block/partitions/core.c. With this change, set_capacity() implementation can be simplified to only calling bdev_set_nr_sectors(). Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20230424131318.79935-1-dlemoal@kernel.org Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 55793ea commit 8379436

4 files changed

Lines changed: 11 additions & 14 deletions

File tree

block/bdev.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,14 @@ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno)
428428
return bdev;
429429
}
430430

431+
void bdev_set_nr_sectors(struct block_device *bdev, sector_t sectors)
432+
{
433+
spin_lock(&bdev->bd_size_lock);
434+
i_size_write(bdev->bd_inode, (loff_t)sectors << SECTOR_SHIFT);
435+
bdev->bd_nr_sectors = sectors;
436+
spin_unlock(&bdev->bd_size_lock);
437+
}
438+
431439
void bdev_add(struct block_device *bdev, dev_t dev)
432440
{
433441
bdev->bd_dev = dev;

block/blk.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,8 @@ int bdev_resize_partition(struct gendisk *disk, int partno, sector_t start,
419419
sector_t length);
420420
void blk_drop_partitions(struct gendisk *disk);
421421

422+
void bdev_set_nr_sectors(struct block_device *bdev, sector_t sectors);
423+
422424
struct gendisk *__alloc_disk_node(struct request_queue *q, int node_id,
423425
struct lock_class_key *lkclass);
424426

block/genhd.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,7 @@ static DEFINE_IDA(ext_devt_ida);
5757

5858
void set_capacity(struct gendisk *disk, sector_t sectors)
5959
{
60-
struct block_device *bdev = disk->part0;
61-
62-
spin_lock(&bdev->bd_size_lock);
63-
i_size_write(bdev->bd_inode, (loff_t)sectors << SECTOR_SHIFT);
64-
bdev->bd_nr_sectors = sectors;
65-
spin_unlock(&bdev->bd_size_lock);
60+
bdev_set_nr_sectors(disk->part0, sectors);
6661
}
6762
EXPORT_SYMBOL(set_capacity);
6863

block/partitions/core.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,6 @@ static int (*check_part[])(struct parsed_partitions *) = {
8585
NULL
8686
};
8787

88-
static void bdev_set_nr_sectors(struct block_device *bdev, sector_t sectors)
89-
{
90-
spin_lock(&bdev->bd_size_lock);
91-
i_size_write(bdev->bd_inode, (loff_t)sectors << SECTOR_SHIFT);
92-
bdev->bd_nr_sectors = sectors;
93-
spin_unlock(&bdev->bd_size_lock);
94-
}
95-
9688
static struct parsed_partitions *allocate_partitions(struct gendisk *hd)
9789
{
9890
struct parsed_partitions *state;

0 commit comments

Comments
 (0)