Skip to content

Commit 83a5ddc

Browse files
committed
platform/x86: panasonic-laptop: revert "Resolve hotkey double trigger bug"
In hindsight blindly throwing away most of the key-press events is not a good idea. So revert commit ed83c91 ("platform/x86: panasonic-laptop: Resolve hotkey double trigger bug"). Fixes: ed83c91 ("platform/x86: panasonic-laptop: Resolve hotkey double trigger bug") Reported-and-tested-by: Stefan Seyfried <seife+kernel@b1-systems.com> Reported-and-tested-by: Kenneth Chan <kenneth.t.chan@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20220624112340.10130-5-hdegoede@redhat.com
1 parent fe4326c commit 83a5ddc

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

drivers/platform/x86/panasonic-laptop.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -783,12 +783,8 @@ static void acpi_pcc_generate_keyinput(struct pcc_acpi *pcc)
783783
key, 0x80, false);
784784
}
785785

786-
/* for the magic values, see panasonic_keymap[] above */
787-
if (key == 7 || key == 9 || key == 10) {
788-
if (!sparse_keymap_report_event(hotk_input_dev,
789-
key, updown, false))
790-
pr_err("Unknown hotkey event: 0x%04llx\n", result);
791-
}
786+
if (!sparse_keymap_report_event(hotk_input_dev, key, updown, false))
787+
pr_err("Unknown hotkey event: 0x%04llx\n", result);
792788
}
793789

794790
static void acpi_pcc_hotkey_notify(struct acpi_device *device, u32 event)

0 commit comments

Comments
 (0)