Skip to content

Commit 8406d6b

Browse files
hal-fengLinus Walleij
authored andcommitted
pinctrl: starfive: jh7110: Fix failure to set irq after CONFIG_PM is enabled
The issue was found when we enabled CONFIG_PM and tested edge events using libgpiod. > # gpiomon -r gpiochip0 55 > gpiomon: error waiting for events: Permission denied `gpiomon` will call irq_chip_pm_get() and then call pm_runtime_resume_and_get() if (IS_ENABLED(CONFIG_PM) && sfp->gc.irq.domain->pm_dev). pm_runtime_resume_and_get() will fail if the runtime pm of pinctrl device is disabled. As we expect the pinctrl driver can be always working and never suspend during runtime, unset sfp->gc.irq.domain->pm_dev to make sure pm_runtime_resume_and_get() won't be called when setting irq. Fixes: 447976a ("pinctrl: starfive: Add StarFive JH7110 sys controller driver") Signed-off-by: Hal Feng <hal.feng@starfivetech.com> Link: https://lore.kernel.org/r/20230905122105.117000-2-hal.feng@starfivetech.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 87d315a commit 8406d6b

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -967,8 +967,6 @@ int jh7110_pinctrl_probe(struct platform_device *pdev)
967967
if (ret)
968968
return dev_err_probe(dev, ret, "could not register gpiochip\n");
969969

970-
irq_domain_set_pm_device(sfp->gc.irq.domain, dev);
971-
972970
dev_info(dev, "StarFive GPIO chip registered %d GPIOs\n", sfp->gc.ngpio);
973971

974972
return pinctrl_enable(sfp->pctl);

0 commit comments

Comments
 (0)