nfp: fix RSS hash key size when RSS is not supported

hyperenju · kuba-moo · commit 8425161ac120 · 2025-09-29T18:33:27.000-07:00
The nfp_net_get_rxfh_key_size() function returns -EOPNOTSUPP when devices don't support RSS, and callers treat the negative value as a large positive value since the return type is u32. Return 0 when devices don't support RSS, aligning with the ethtool interface .get_rxfh_key_size() that requires returning 0 in such cases. Fixes: 9ff304b ("nfp: add support for reporting CRC32 hash function") Signed-off-by: Kohei Enju <enjuk@amazon.com> Link: https://patch.msgid.link/20250929054230.68120-1-enjuk@amazon.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
@@ -1788,7 +1788,7 @@ static u32 nfp_net_get_rxfh_key_size(struct net_device *netdev)
 	struct nfp_net *nn = netdev_priv(netdev);
 
 	if (!(nn->cap & NFP_NET_CFG_CTRL_RSS_ANY))
-		return -EOPNOTSUPP;
+		return 0;
 
 	return nfp_net_rss_key_sz(nn);
 }

Original file line number	Diff line number	Diff line change
`@@ -1788,7 +1788,7 @@ static u32 nfp_net_get_rxfh_key_size(struct net_device *netdev)`
`1788`	`1788`	`struct nfp_net *nn = netdev_priv(netdev);`
`1789`	`1789`
`1790`	`1790`	`if (!(nn->cap & NFP_NET_CFG_CTRL_RSS_ANY))`
`1791`		`- return -EOPNOTSUPP;`
	`1791`	`+ return 0;`
`1792`	`1792`
`1793`	`1793`	`return nfp_net_rss_key_sz(nn);`
`1794`	`1794`	`}`