Skip to content

Commit 842df74

Browse files
DispatchCodejgross1
authored andcommitted
xen/events: replace use of system_wq with system_percpu_wq
Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") Switch to using system_percpu_wq because system_wq is going away as part of a workqueue restructuring. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: Juergen Gross <jgross@suse.com> Message-ID: <20251106155831.306248-2-marco.crivellari@suse.com>
1 parent 0f61b18 commit 842df74

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/xen/events/events_base.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,7 @@ static void lateeoi_list_add(struct irq_info *info)
581581
eoi_list);
582582
if (!elem || info->eoi_time < elem->eoi_time) {
583583
list_add(&info->eoi_list, &eoi->eoi_list);
584-
mod_delayed_work_on(info->eoi_cpu, system_wq,
584+
mod_delayed_work_on(info->eoi_cpu, system_percpu_wq,
585585
&eoi->delayed, delay);
586586
} else {
587587
list_for_each_entry_reverse(elem, &eoi->eoi_list, eoi_list) {
@@ -666,7 +666,7 @@ static void xen_irq_lateeoi_worker(struct work_struct *work)
666666
break;
667667

668668
if (now < info->eoi_time) {
669-
mod_delayed_work_on(info->eoi_cpu, system_wq,
669+
mod_delayed_work_on(info->eoi_cpu, system_percpu_wq,
670670
&eoi->delayed,
671671
info->eoi_time - now);
672672
break;
@@ -782,7 +782,7 @@ static void xen_free_irq(struct irq_info *info)
782782

783783
WARN_ON(info->refcnt > 0);
784784

785-
queue_rcu_work(system_wq, &info->rwork);
785+
queue_rcu_work(system_percpu_wq, &info->rwork);
786786
}
787787

788788
/* Not called for lateeoi events. */

0 commit comments

Comments
 (0)