Skip to content

Commit 84a60bb

Browse files
vladimirolteankuba-moo
authored andcommitted
net: dsa: tag_mtk: use the dsa_xmit_port_mask() helper
The "mtk" tagging protocol populates a bit mask for the TX ports, so we can use dsa_xmit_port_mask() to centralize the decision of how to set that field. Cc: Chester A. Unal" <chester.a.unal@arinc9.com> Cc: Daniel Golle <daniel@makrotopia.org> Cc: DENG Qingfang <dqfext@gmail.com> Cc: Sean Wang <sean.wang@mediatek.com> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://patch.msgid.link/20251127120902.292555-7-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ea659a9 commit 84a60bb

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

net/dsa/tag_mtk.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb,
5454
* whether that's a combined special tag with 802.1Q header.
5555
*/
5656
mtk_tag[0] = xmit_tpid;
57-
mtk_tag[1] = (1 << dp->index) & MTK_HDR_XMIT_DP_BIT_MASK;
57+
mtk_tag[1] = FIELD_PREP(MTK_HDR_XMIT_DP_BIT_MASK,
58+
dsa_xmit_port_mask(skb, dev));
5859

5960
/* Tag control information is kept for 802.1Q */
6061
if (xmit_tpid == MTK_HDR_XMIT_UNTAGGED) {

0 commit comments

Comments
 (0)