Skip to content

Commit 852405d

Browse files
Evan BennEnric Balletbo i Serra
authored andcommitted
platform/chrome: cros_ec_proto: Add LID and BATTERY to default mask
After 'platform/chrome: cros_ec_proto: Use EC_HOST_EVENT_MASK not BIT' some of the flags are not quite correct. LID_CLOSED is used to suspend the device, so it makes sense to ignore that. BATTERY events are also frequent and causing spurious wakes on elm/hana mt8173 devices. Fixes: c214e56 ("platform/chrome: cros_ec_proto: ignore unnecessary wakeups on old ECs") Signed-off-by: Evan Benn <evanbenn@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Link: https://lore.kernel.org/r/20201209220306.2.I3291bf83e4884c206b097ede34780e014fa3e265@changeid
1 parent 0944ea0 commit 852405d

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/platform/chrome/cros_ec_proto.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,9 +526,11 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
526526
* power), not wake up.
527527
*/
528528
ec_dev->host_event_wake_mask = U32_MAX &
529-
~(EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |
529+
~(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED) |
530+
EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |
530531
EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_LOW) |
531532
EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |
533+
EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY) |
532534
EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |
533535
EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS));
534536
/*

0 commit comments

Comments
 (0)