RDMA/siw: replace redundant ternary operator with just rv

ColinIanKing · rleon · commit 8536666a5283 · 2025-05-12T06:20:24.000-04:00
The use of the ternary operator on rv is redundant, rv is either the initialized value of 0 or a negative error return code, so it can never be greater than zero, and hence the zero assignment in ternary operator is redundant. Just return rv instead. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://patch.msgid.link/20250507131834.253823-1-colin.i.king@gmail.com Acked-by: Bernard Metzler <bmt@zurich.ibm.com> Signed-off-by: Leon Romanovsky <leon@kernel.org>
diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c
@@ -1102,7 +1102,7 @@ int siw_post_receive(struct ib_qp *base_qp, const struct ib_recv_wr *wr,
 		siw_dbg_qp(qp, "error %d\n", rv);
 		*bad_wr = wr;
 	}
-	return rv > 0 ? 0 : rv;
+	return rv;
 }
 
 int siw_destroy_cq(struct ib_cq *base_cq, struct ib_udata *udata)

Original file line number	Diff line number	Diff line change
`@@ -1102,7 +1102,7 @@ int siw_post_receive(struct ib_qp base_qp, const struct ib_recv_wr wr,`
`1102`	`1102`	`siw_dbg_qp(qp, "error %d\n", rv);`
`1103`	`1103`	`*bad_wr = wr;`
`1104`	`1104`	`}`
`1105`		`- return rv > 0 ? 0 : rv;`
	`1105`	`+ return rv;`
`1106`	`1106`	`}`
`1107`	`1107`
`1108`	`1108`	`int siw_destroy_cq(struct ib_cq base_cq, struct ib_udata udata)`