Skip to content

Commit 85463eb

Browse files
mrgolinjgunthorpe
authored andcommitted
RDMA/efa: Remove possible negative shift
The page size used for device might in some cases be smaller than PAGE_SIZE what results in a negative shift when calculating the number of host pages in PAGE_SIZE for a debug log. Remove the debug line together with the calculation. Fixes: 40909f6 ("RDMA/efa: Add EFA verbs implementation") Link: https://patch.msgid.link/r/20251210173656.8180-1-mrgolin@amazon.com Reviewed-by: Tom Sela <tomsela@amazon.com> Reviewed-by: Yonatan Nachum <ynachum@amazon.com> Signed-off-by: Michael Margolin <mrgolin@amazon.com> Reviewed-by: Gal Pressman <gal.pressman@linux.dev> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
1 parent c1776cc commit 85463eb

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/infiniband/hw/efa/efa_verbs.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1320,13 +1320,9 @@ static int umem_to_page_list(struct efa_dev *dev,
13201320
u32 hp_cnt,
13211321
u8 hp_shift)
13221322
{
1323-
u32 pages_in_hp = BIT(hp_shift - PAGE_SHIFT);
13241323
struct ib_block_iter biter;
13251324
unsigned int hp_idx = 0;
13261325

1327-
ibdev_dbg(&dev->ibdev, "hp_cnt[%u], pages_in_hp[%u]\n",
1328-
hp_cnt, pages_in_hp);
1329-
13301326
rdma_umem_for_each_dma_block(umem, &biter, BIT(hp_shift))
13311327
page_list[hp_idx++] = rdma_block_iter_dma_address(&biter);
13321328

0 commit comments

Comments
 (0)