Skip to content

Commit 860e36b

Browse files
Wolfram Sangjic23
authored andcommitted
iio: adc: exynos_adc: use 'time_left' variable with wait_for_completion_timeout()
There is a confusing pattern in the kernel to use a variable named 'timeout' to store the result of wait_for_completion_timeout() causing patterns like: timeout = wait_for_completion_timeout(...) if (!timeout) return -ETIMEDOUT; with all kinds of permutations. Use 'time_left' as a variable to make the code self explaining. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Link: https://lore.kernel.org/r/20240429113313.68359-3-wsa+renesas@sang-engineering.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent 4d68b25 commit 860e36b

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

drivers/iio/adc/exynos_adc.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ static int exynos_read_raw(struct iio_dev *indio_dev,
538538
long mask)
539539
{
540540
struct exynos_adc *info = iio_priv(indio_dev);
541-
unsigned long timeout;
541+
unsigned long time_left;
542542
int ret;
543543

544544
if (mask == IIO_CHAN_INFO_SCALE) {
@@ -562,9 +562,9 @@ static int exynos_read_raw(struct iio_dev *indio_dev,
562562
if (info->data->start_conv)
563563
info->data->start_conv(info, chan->address);
564564

565-
timeout = wait_for_completion_timeout(&info->completion,
566-
EXYNOS_ADC_TIMEOUT);
567-
if (timeout == 0) {
565+
time_left = wait_for_completion_timeout(&info->completion,
566+
EXYNOS_ADC_TIMEOUT);
567+
if (time_left == 0) {
568568
dev_warn(&indio_dev->dev, "Conversion timed out! Resetting\n");
569569
if (info->data->init_hw)
570570
info->data->init_hw(info);
@@ -583,7 +583,7 @@ static int exynos_read_raw(struct iio_dev *indio_dev,
583583
static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
584584
{
585585
struct exynos_adc *info = iio_priv(indio_dev);
586-
unsigned long timeout;
586+
unsigned long time_left;
587587
int ret;
588588

589589
mutex_lock(&info->lock);
@@ -597,9 +597,9 @@ static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
597597
/* Select the ts channel to be used and Trigger conversion */
598598
info->data->start_conv(info, ADC_S3C2410_MUX_TS);
599599

600-
timeout = wait_for_completion_timeout(&info->completion,
601-
EXYNOS_ADC_TIMEOUT);
602-
if (timeout == 0) {
600+
time_left = wait_for_completion_timeout(&info->completion,
601+
EXYNOS_ADC_TIMEOUT);
602+
if (time_left == 0) {
603603
dev_warn(&indio_dev->dev, "Conversion timed out! Resetting\n");
604604
if (info->data->init_hw)
605605
info->data->init_hw(info);

0 commit comments

Comments
 (0)