Skip to content

Commit 8614afd

Browse files
matthew-gerlachmfischer
authored andcommitted
fpga: dfl: fix bug in port reset handshake
When putting the port in reset, driver must wait for the soft reset acknowledgment bit instead of the soft reset bit. Fixes: 47c1b19 (fpga: dfl: afu: add port ops support) Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> Signed-off-by: Xu Yilun <yilun.xu@intel.com> Acked-by: Wu Hao <hao.wu@intel.com> Reviewed-by: Tom Rix <trix@redhat.com> Signed-off-by: Moritz Fischer <mdf@kernel.org>
1 parent e19485d commit 8614afd

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/fpga/dfl-afu-main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ int __afu_port_disable(struct platform_device *pdev)
8383
* on this port and minimum soft reset pulse width has elapsed.
8484
* Driver polls port_soft_reset_ack to determine if reset done by HW.
8585
*/
86-
if (readq_poll_timeout(base + PORT_HDR_CTRL, v, v & PORT_CTRL_SFTRST,
86+
if (readq_poll_timeout(base + PORT_HDR_CTRL, v,
87+
v & PORT_CTRL_SFTRST_ACK,
8788
RST_POLL_INVL, RST_POLL_TIMEOUT)) {
8889
dev_err(&pdev->dev, "timeout, fail to reset device\n");
8990
return -ETIMEDOUT;

0 commit comments

Comments
 (0)