Commit 8616718
igc: fix a log entry using uninitialized netdev
During successful probe, igc logs this:
[ 5.133667] igc 0000:01:00.0 (unnamed net_device) (uninitialized): PHC added
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The reason is that igc_ptp_init() is called very early, even before
register_netdev() has been called. So the netdev_info() call works
on a partially uninitialized netdev.
Fix this by calling igc_ptp_init() after register_netdev(), right
after the media autosense check, just as in igb. Add a comment,
just as in igb.
Now the log message is fine:
[ 5.200987] igc 0000:01:00.0 eth0: PHC added
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>1 parent 8e3a90f commit 8616718
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7028 | 7028 | | |
7029 | 7029 | | |
7030 | 7030 | | |
7031 | | - | |
7032 | | - | |
7033 | 7031 | | |
7034 | 7032 | | |
7035 | 7033 | | |
| |||
7051 | 7049 | | |
7052 | 7050 | | |
7053 | 7051 | | |
| 7052 | + | |
| 7053 | + | |
| 7054 | + | |
7054 | 7055 | | |
7055 | 7056 | | |
7056 | 7057 | | |
| |||
0 commit comments