Skip to content

Commit 86295cb

Browse files
Alexander GordeevVasily Gorbik
authored andcommitted
s390/kdump: cleanup do_start_kdump() prototype and usage
Avoid unnecessary run-time and compile-time type conversions of do_start_kdump() function return value and parameter. Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com> Reviewed-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
1 parent 7a04d49 commit 86295cb

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

arch/s390/kernel/machine_kexec.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,8 @@ static noinline void __machine_kdump(void *image)
111111
store_status(__do_machine_kdump, image);
112112
}
113113

114-
static unsigned long do_start_kdump(unsigned long addr)
114+
static int do_start_kdump(struct kimage *image)
115115
{
116-
struct kimage *image = (struct kimage *) addr;
117116
int (*start_kdump)(int) = (void *)image->start;
118117
int rc;
119118

@@ -134,8 +133,8 @@ static bool kdump_csum_valid(struct kimage *image)
134133
int rc;
135134

136135
preempt_disable();
137-
rc = call_on_stack(1, S390_lowcore.nodat_stack, unsigned long, do_start_kdump,
138-
unsigned long, (unsigned long)image);
136+
rc = call_on_stack(1, S390_lowcore.nodat_stack, int, do_start_kdump,
137+
struct kimage *, image);
139138
preempt_enable();
140139
return rc == 0;
141140
#else

0 commit comments

Comments
 (0)