net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()

Dan Carpenter · Paolo Abeni · commit 86360030cc51 · 2022-06-01T13:32:04.000+02:00
The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return false on failure. It should not return negatives because that means succes/true. Fixes: fcb6aa8 ("act_ct: Support GRE offload") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Toshiaki Makita <toshiaki.makita1@gmail.com> Link: https://lore.kernel.org/r/YpYFnbDxFl6tQ3Bn@kili Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
@@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb,
 		break;
 #endif
 	default:
-		return -1;
+		return false;
 	}
 
 	if (ip6h->hop_limit <= 1)

Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb,`
`548`	`548`	`break;`
`549`	`549`	`#endif`
`550`	`550`	`default:`
`551`		`- return -1;`
	`551`	`+ return false;`
`552`	`552`	`}`
`553`	`553`
`554`	`554`	`if (ip6h->hop_limit <= 1)`