Skip to content

Commit 865e63b

Browse files
committed
clk: milbeaut: convert from divider_round_rate() to divider_determine_rate()
The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate = divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 7b45988 ("clk: milbeaut: convert from round_rate() to determine_rate()") Signed-off-by: Brian Masney <bmasney@redhat.com>
1 parent fc5d7e7 commit 865e63b

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/clk/clk-milbeaut.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -403,10 +403,7 @@ static int m10v_clk_divider_determine_rate(struct clk_hw *hw,
403403
val);
404404
}
405405

406-
req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
407-
divider->table, divider->width, divider->flags);
408-
409-
return 0;
406+
return divider_determine_rate(hw, req, divider->table, divider->width, divider->flags);
410407
}
411408

412409
static int m10v_clk_divider_set_rate(struct clk_hw *hw, unsigned long rate,

0 commit comments

Comments
 (0)