Skip to content

Commit 86aeda3

Browse files
Amit EngelChristoph Hellwig
authored andcommitted
nvmet-tcp: fix header digest verification
Pass the correct length to nvmet_tcp_verify_hdgst, which is the pdu header length. This fixes a wrong behaviour where header digest verification passes although the digest is wrong. Signed-off-by: Amit Engel <amit.engel@dell.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent e790de5 commit 86aeda3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/nvme/target/tcp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1096,7 +1096,7 @@ static int nvmet_tcp_try_recv_pdu(struct nvmet_tcp_queue *queue)
10961096
}
10971097

10981098
if (queue->hdr_digest &&
1099-
nvmet_tcp_verify_hdgst(queue, &queue->pdu, queue->offset)) {
1099+
nvmet_tcp_verify_hdgst(queue, &queue->pdu, hdr->hlen)) {
11001100
nvmet_tcp_fatal_error(queue); /* fatal */
11011101
return -EPROTO;
11021102
}

0 commit comments

Comments
 (0)