Skip to content

Commit 8771b7f

Browse files
pinchartlHans Verkuil
authored andcommitted
media: bcm2835-unicam: Depend on COMMON_CLK
The bcm2835-unicam driver calls the clk_set_min_rate() function, which is declared but not implemented on platforms that don't provide COMMON_CLK. This causes linkage failures with some configurations. Fix it by depending on COMMON_CLK. This only slightly restricts compilation testing, but not usage of the driver as all platforms on which the hardware can be found provide COMMON_CLK. Fixes: 392cd78 ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202405112243.2MLRT7li-lkp@intel.com/ Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent eba63df commit 8771b7f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/media/platform/broadcom

drivers/media/platform/broadcom/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
config VIDEO_BCM2835_UNICAM
44
tristate "Broadcom BCM283x/BCM271x Unicam video capture driver"
55
depends on ARCH_BCM2835 || COMPILE_TEST
6-
depends on PM
6+
depends on COMMON_CLK && PM
77
depends on VIDEO_DEV
88
select MEDIA_CONTROLLER
99
select V4L2_FWNODE

0 commit comments

Comments
 (0)