regulator: max20086: fix error code in max20086_parse_regulators_dt()

Dan Carpenter · broonie · commit 879cf8006475 · 2022-01-11T13:48:49.000Z
This code accidentally returns PTR_ERR(NULL) which is success. It should return a negative error code. Fixes: bfff546 ("regulator: Add MAX20086-MAX20089 driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://lore.kernel.org/r/20220111072657.GK11243@kili Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max20086-regulator.c
@@ -140,7 +140,7 @@ static int max20086_parse_regulators_dt(struct max20086 *chip, bool *boot_on)
 	node = of_get_child_by_name(chip->dev->of_node, "regulators");
 	if (!node) {
 		dev_err(chip->dev, "regulators node not found\n");
-		return PTR_ERR(node);
+		return -ENODEV;
 	}
 
 	for (i = 0; i < chip->info->num_outputs; ++i)

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ static int max20086_parse_regulators_dt(struct max20086 chip, bool boot_on)`
`140`	`140`	`node = of_get_child_by_name(chip->dev->of_node, "regulators");`
`141`	`141`	`if (!node) {`
`142`	`142`	`dev_err(chip->dev, "regulators node not found\n");`
`143`		`- return PTR_ERR(node);`
	`143`	`+ return -ENODEV;`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`for (i = 0; i < chip->info->num_outputs; ++i)`