Skip to content

Commit 87b8ee6

Browse files
sreedeviintelanguy11
authored andcommitted
idpf: Fix error handling in idpf_vport_open()
Fix error handling to properly cleanup interrupts when idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to 'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned up before releasing other resources. Fixes: d4d5587 ("idpf: initialize interrupts and enable vport") Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com> Reviewed-by: Madhu Chittim <madhu.chittim@intel.com> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Samuel Salin <Samuel.salin@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent ebecca5 commit 87b8ee6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/intel/idpf/idpf_lib.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1524,14 +1524,14 @@ static int idpf_vport_open(struct idpf_vport *vport, bool rtnl)
15241524
if (err) {
15251525
dev_err(&adapter->pdev->dev, "Failed to initialize queue registers for vport %u: %d\n",
15261526
vport->vport_id, err);
1527-
goto queues_rel;
1527+
goto intr_deinit;
15281528
}
15291529

15301530
err = idpf_rx_bufs_init_all(vport);
15311531
if (err) {
15321532
dev_err(&adapter->pdev->dev, "Failed to initialize RX buffers for vport %u: %d\n",
15331533
vport->vport_id, err);
1534-
goto queues_rel;
1534+
goto intr_deinit;
15351535
}
15361536

15371537
idpf_rx_init_buf_tail(vport);

0 commit comments

Comments
 (0)