Skip to content

Commit 87cb4a6

Browse files
tdzmlankhorst
authored andcommitted
drm/fbdev-generic: Do not set physical framebuffer address
Framebuffer memory is allocated via vzalloc() from non-contiguous physical pages. The physical framebuffer start address is therefore meaningless. Do not set it. The value is not used within the kernel and only exported to userspace on dedicated ARM configs. No functional change is expected. v2: - refer to vzalloc() in commit message (Javier) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: a5b44c4 ("drm/fbdev-generic: Always use shadow buffering") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Zack Rusin <zackr@vmware.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: <stable@vger.kernel.org> # v6.4+ Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Zack Rusin <zack.rusin@broadcom.com> Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev> Tested-by: Sui Jingfeng <sui.jingfeng@linux.dev> Acked-by: Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240419083331.7761-2-tzimmermann@suse.de (cherry picked from commit 73ef0ae) Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
1 parent 2fa42fd commit 87cb4a6

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/gpu/drm/drm_fbdev_generic.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ static int drm_fbdev_generic_helper_fb_probe(struct drm_fb_helper *fb_helper,
113113
/* screen */
114114
info->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST;
115115
info->screen_buffer = screen_buffer;
116-
info->fix.smem_start = page_to_phys(vmalloc_to_page(info->screen_buffer));
117116
info->fix.smem_len = screen_size;
118117

119118
/* deferred I/O */

0 commit comments

Comments
 (0)