Skip to content

Commit 8860d86

Browse files
nathanchanceshuahkh
authored andcommitted
selftests: x86: ksft_exit_pass() does not return
After commit f7d5bcd ("selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn"), ksft_exit_...() functions are marked as __noreturn, which means the return type should not be 'int' but 'void' because they are not returning anything (and never were since exit() has always been called). To facilitate updating the return type of these functions, remove 'return' before the call to ksft_exit_pass(), as __noreturn prevents the compiler from warning that a caller of ksft_exit_pass() does not return a value because the program will terminate upon calling these functions. Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Reviewed-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
1 parent bc7e5d2 commit 8860d86

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • tools/testing/selftests/x86

tools/testing/selftests/x86/lam.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1237,5 +1237,5 @@ int main(int argc, char **argv)
12371237

12381238
ksft_set_plan(tests_cnt);
12391239

1240-
return ksft_exit_pass();
1240+
ksft_exit_pass();
12411241
}

0 commit comments

Comments
 (0)