Skip to content

Commit 88f04bc

Browse files
KunWuChansre
authored andcommitted
power: supply: Fix null pointer dereference in smb2_probe
devm_kasprintf and devm_kzalloc return a pointer to dynamically allocated memory which can be NULL upon failure. Fixes: 8648aeb ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver") Signed-off-by: Kunwu Chan <chentao@kylinos.cn> Link: https://lore.kernel.org/r/20231124075021.1335289-1-chentao@kylinos.cn Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent 195c316 commit 88f04bc

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/power/supply/qcom_pmi8998_charger.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -972,10 +972,14 @@ static int smb2_probe(struct platform_device *pdev)
972972
supply_config.of_node = pdev->dev.of_node;
973973

974974
desc = devm_kzalloc(chip->dev, sizeof(smb2_psy_desc), GFP_KERNEL);
975+
if (!desc)
976+
return -ENOMEM;
975977
memcpy(desc, &smb2_psy_desc, sizeof(smb2_psy_desc));
976978
desc->name =
977979
devm_kasprintf(chip->dev, GFP_KERNEL, "%s-charger",
978980
(const char *)device_get_match_data(chip->dev));
981+
if (!desc->name)
982+
return -ENOMEM;
979983

980984
chip->chg_psy =
981985
devm_power_supply_register(chip->dev, desc, &supply_config);

0 commit comments

Comments
 (0)