rcu-tasks: Correct firstreport usage in check_all_holdout_tasks_trace

Neeraj Upadhyay · paulmckrcu · commit 89401176daf0 · 2021-09-15T11:37:51.000-07:00
In check_all_holdout_tasks_trace(), firstreport is a pointer argument;
so, check the dereferenced value, instead of checking the pointer.

Signed-off-by: Neeraj Upadhyay &lt;neeraju@codeaurora.org&gt;
Signed-off-by: Paul E. McKenney &lt;paulmck@kernel.org&gt;
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
@@ -1129,7 +1129,7 @@ static void check_all_holdout_tasks_trace(struct list_head *hop,
 	cpus_read_unlock();
 
 	if (needreport) {
-		if (firstreport)
+		if (*firstreport)
 			pr_err("INFO: rcu_tasks_trace detected stalls? (Late IPI?)\n");
 		show_stalled_ipi_trace();
 	}

Original file line number	Diff line number	Diff line change
`@@ -1129,7 +1129,7 @@ static void check_all_holdout_tasks_trace(struct list_head *hop,`
`1129`	`1129`	`cpus_read_unlock();`
`1130`	`1130`
`1131`	`1131`	`if (needreport) {`
`1132`		`- if (firstreport)`
	`1132`	`+ if (*firstreport)`
`1133`	`1133`	`pr_err("INFO: rcu_tasks_trace detected stalls? (Late IPI?)\n");`
`1134`	`1134`	`show_stalled_ipi_trace();`
`1135`	`1135`	`}`