Skip to content

Commit 89531b6

Browse files
floatiousdamien-lemoal
authored andcommitted
ata: libata: Add DIPM and HIPM to ata_dev_print_features() early return
ata_dev_print_features() is supposed to return early and not print anything if there are no features supported. However, commit b1f5af5 ("ata: libata-core: Advertize device support for DIPM and HIPM features") added additional features to ata_dev_print_features() without updating the early return conditional. Add the missing features to the early return conditional. Fixes: b1f5af5 ("ata: libata-core: Advertize device support for DIPM and HIPM features") Signed-off-by: Niklas Cassel <cassel@kernel.org> Tested-by: Wolf <wolf@yoxt.cc> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
1 parent a6bee5e commit 89531b6

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/ata/libata-core.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2872,7 +2872,8 @@ static void ata_dev_config_lpm(struct ata_device *dev)
28722872

28732873
static void ata_dev_print_features(struct ata_device *dev)
28742874
{
2875-
if (!(dev->flags & ATA_DFLAG_FEATURES_MASK) && !dev->cpr_log)
2875+
if (!(dev->flags & ATA_DFLAG_FEATURES_MASK) && !dev->cpr_log &&
2876+
!ata_id_has_hipm(dev->id) && !ata_id_has_dipm(dev->id))
28762877
return;
28772878

28782879
ata_dev_info(dev,

0 commit comments

Comments
 (0)