Skip to content

Commit 8958389

Browse files
billy-tsaiMarc Zyngier
authored andcommitted
irqchip/aspeed-scu: Replace update_bits with write_bits.
The interrupt status bits are cleared by writing 1, we should force a write to clear the interrupt without checking if the value has changed. Fixes: 04f6059 ("irqchip: Add Aspeed SCU interrupt controller") Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Reviewed-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20211124094348.11621-1-billy_tsai@aspeedtech.com Cc: stable@vger.kernel.org
1 parent d0a5535 commit 8958389

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/irqchip/irq-aspeed-scu-ic.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ static void aspeed_scu_ic_irq_handler(struct irq_desc *desc)
7676
generic_handle_domain_irq(scu_ic->irq_domain,
7777
bit - scu_ic->irq_shift);
7878

79-
regmap_update_bits(scu_ic->scu, scu_ic->reg, mask,
80-
BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT));
79+
regmap_write_bits(scu_ic->scu, scu_ic->reg, mask,
80+
BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT));
8181
}
8282

8383
chained_irq_exit(chip, desc);

0 commit comments

Comments
 (0)